Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up metalc #221

Merged
merged 12 commits into from
Mar 3, 2021
Merged

Cleaning up metalc #221

merged 12 commits into from
Mar 3, 2021

Conversation

TimStewartJ
Copy link
Member

@TimStewartJ TimStewartJ commented Jan 20, 2021 •
edited by sandertyu
Loading

There's lots of out of date things that need to be cleaned out. Relevant to issue #185

Checklist of things that need cleaning/revamping (things with (??) I am unsure about):

  • dev-env (archive)
  • Docs:
    • Bare-Metal:
      • baremetal.md (moved to flock-archive/)
      • login.md (updated with up-to-date info)
      • ZFS.md (keep)
      • concepts: (most of these seem to still be relevant, not too sure what the purpose of them is but nice to keep around)
        • linux.md
        • networking.md
        • nginx.md (still refers to rooster as reverse-proxy and load-balancer, needs updating)
        • persistentvolumes.md
        • RAID.md
      • troubleshooting (It seems like all of these are still relevant, if someone could look over them and confirm that would be nice)
        • AddingNotReadyNode.md
        • DeletedKubeDNSService.md
        • FixingBinderHub.md
        • HTTPSonJupyterHub.md
        • KubeadmCert.md
        • NetworkingFailInPodsOnSpecificNodes.md
        • README.md (fixed broken links)
        • Repo2DockerErrors.md
        • Troubleshooting-JupyterHub.md
        • Z2JHServingHTTPOnPort443.md
    • Binder-on-GCloud
    • JupyterHub-on-GCloud
    • images
    • Virtual-Machine
    • Galaxy-Control-Repo.md (I'm assuming it's already up to date)
    • maintenance-tasks.md (I started updating it for galaxy, there are still a couple changes that need to be made)
    • Onboarding.md
    • Updating-ubuntu-kubernetes

@mandeepika
Copy link
Contributor

I checked the Onboarding.md in the comment above, since I updated it a couple of days ago. (Unless there is something that you were thinking of adding to it @TimStewartJ)

@sandertyu
Copy link
Contributor

Looks good to merge. Might want to check maintenance-tasks.md, that's the only one i didn't archive.

@TimStewartJ
Copy link
Member Author

Alright, I tried to update maintenance-tasks.md to the best of my ability, if someone could look over that and make sure the information is indeed correct that would be great. I'll mark this as ready for review as well.

@TimStewartJ TimStewartJ marked this pull request as ready for review March 2, 2021 05:02
sandertyu
sandertyu reviewed Mar 2, 2021
View reviewed changes
docs/maintenance-tasks.md Outdated Show resolved Hide resolved
sandertyu
sandertyu reviewed Mar 2, 2021
View reviewed changes
docs/maintenance-tasks.md Outdated Show resolved Hide resolved
sandertyu
sandertyu requested changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@sandertyu sandertyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious about my comments made to maintenance-tasks.md, then it seems good to me to merge

@pmackle
Copy link

pmackle commented Mar 3, 2021

Why is it exactly we are keeping ZFS.md? I am wondering how much of the hardware portion is still accurate or if it would be better put in /flock-archive.

@sandertyu
Copy link
Contributor

Why is it exactly we are keeping ZFS.md? I am wondering how much of the hardware portion is still accurate or if it would be better put in /flock-archive.

ZFS.md is all about the blackhole file server (previously hen) and I guess some other hardware in our cluster. It looks good to keep.

Looks fine to me if @TimStewartJ wants to merge.

@moorepants moorepants merged commit 639d0c7 into master Mar 3, 2021
@TimStewartJ TimStewartJ deleted the spring-cleaning branch August 30, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandertyu sandertyu sandertyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimStewartJ @mandeepika @sandertyu @pmackle @moorepants